Revert "Holocene extensions to L1Block.sol (#12096)"#12236
Merged
tynes merged 1 commit intoethereum-optimism:developfrom Oct 1, 2024
Merged
Revert "Holocene extensions to L1Block.sol (#12096)"#12236tynes merged 1 commit intoethereum-optimism:developfrom
tynes merged 1 commit intoethereum-optimism:developfrom
Conversation
This reverts commit 5bd72f6.
roberto-bayardo
force-pushed
the
revert-l1block-holocene
branch
from
3a8400f to
3a3400d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12236 +/- ##
===========================================
- Coverage 72.19% 71.99% -0.21%
===========================================
Files 50 50
Lines 3910 3910
===========================================
- Hits 2823 2815 -8
- Misses 901 910 +9
+ Partials 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Inphi
approved these changes
Oct 1, 2024
tynes
approved these changes
Oct 1, 2024
Contributor
Yes exactly |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 5bd72f6, due to the recent spec change involving using block header to provide eip1559 fields instead of the l1 attributes.